[GSoC2024] feat: add shortcut support for pinning properties #7709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahamukhtar20
changed the title
|
@bsekachev please have a look, the concerned issue is fixed. Thanks |
|
Hi, @bsekachev please let me know if there is something that is left in this PR, I'll work on it. |
|
@bsekachev any updates on this one? |
bsekachev
approved these changes
Apr 10, 2024
|
Thanks, nice patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes: #3577
How has this been tested?
The issue was an enhancement, and it was a feature request for a new shortcut. There were shortcuts of the buttons available near this one, but this one didn't have any shortcut assigned to it, hence "p" is now used to pin or unpin, it has been tested under different key pattern. Couldn't find any related test cases if there are any please let me know, I'll update the test cases.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.