-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding French translations #90
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for this effort. |
Oh, I was about to point out that I've made mnemonics translatable but I see that you already did it (I've missed one though 😛 !) ! |
Ok thanks. It would be nice btw. if you could open separate PRs for these additional fixes. It makes reviewing easier and I can merge them faster. |
I agree, I won't do any change in the code (or I'll open another PR) ! I'll just concentrate on making this merge-able (since changes in master were made) and fixing some grammar/semantic errors ! |
Hi! Sorry for this late answer, I had urgent things to do before. As you asked me to do, I removed all my local code changes, limiting it only to translation. And I based this PR on the latest commit. And I fixed some errors, some might still have slipped through. |
Thanks. Is it still WIP? |
I just forgot the edit the title! It no longer is WIP. |
Is there a shorter word for "warning" and "badbox" maybe? |
Wow, so I closed the PR by accident, sorry for that (I restarted Firefox while writing the comment, and I think somehow GitHub interpreted that as close the PR and send the unfinished comment)! |
For "warning" there's "alerte". For "badbox", "débordement" isn't a good translation, but I cannot find any better... A good translation would be "problème de mise en page" but it is way too long... But after some thinking, I'll keep the English term badbox like in other translations :)! |
"alerte" and "badbox" are fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a native speaker of French.
|
||
#: setzer/workspace/sidebar/sidebar.py:49 | ||
msgid "Misc. Math" | ||
msgstr "Divers symboles mathématiques" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be
msgstr "Divers symboles mathématiques" | |
msgstr "Symboles mathématiques divers" |
but as I said I'm not a native speaker. Same below: Symboles divers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are valid ! But, I do prefer "Divers symboles" over "Symboles divers".
Thank you a lot for this review ❤️ ! This was my first try at translating a software, and, it's quite hard 😛. I'll reread my entire translation to fix any other grammar errors I might catch. Unfortunately, until the 3rd of September, I'm quite busy, so I don't think I'll have a good translation until then. I really wanted a French-speaking reviewer to review the translation, and I can't thank you more for finding those errors 😁 ! |
ecd418a
to
1d5ebde
Compare
7005732
to
f2758a7
Compare
8cd8a32
to
124135e
Compare
b9b6716
to
fd013b2
Compare
04c3bad
to
5788929
Compare
4322fba
to
f97e371
Compare
Hi @LyesSaadi, is this still WIP? We are integrating Weblate and would like to add your contribution through it, is that okay? Thank you! |
Hi!
So I translated the entirety of Setzer...
I
surelymight have done some spelling/grammar errors (I caught one just earlier), so I still have to review all of my translations again!I also still need to be sure that what I translated is coherent with the context in which the string appeared.
PS: I never used BibTeX (only LaTeX), so I might have mistranslated some strings. I did my best to understand all terms
by doing some web searches, but I'll be grateful if some fellow French speaker that used it could maybe review what I translated to be 100% sure that no error slipped through !