Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding French translations #90

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LyesSaadi
Copy link
Contributor

This is a WIP: everything is translated, but I still have to test things!

Hi!

So I translated the entirety of Setzer...

I surely might have done some spelling/grammar errors (I caught one just earlier), so I still have to review all of my translations again!

I also still need to be sure that what I translated is coherent with the context in which the string appeared.

PS: I never used BibTeX (only LaTeX), so I might have mistranslated some strings. I did my best to understand all terms by doing some web searches, but I'll be grateful if some fellow French speaker that used it could maybe review what I translated to be 100% sure that no error slipped through !

@cvfosammmm
Copy link
Owner

Thanks a lot for this effort.

@LyesSaadi
Copy link
Contributor Author

Oh, I was about to point out that I've made mnemonics translatable but I see that you already did it (I've missed one though 😛 !) !

@cvfosammmm
Copy link
Owner

Ok thanks. It would be nice btw. if you could open separate PRs for these additional fixes. It makes reviewing easier and I can merge them faster.

@LyesSaadi
Copy link
Contributor Author

LyesSaadi commented May 11, 2020

I agree, I won't do any change in the code (or I'll open another PR) ! I'll just concentrate on making this merge-able (since changes in master were made) and fixing some grammar/semantic errors !

@LyesSaadi LyesSaadi marked this pull request as ready for review May 20, 2020 21:51
@LyesSaadi
Copy link
Contributor Author

Hi!

Sorry for this late answer, I had urgent things to do before.

As you asked me to do, I removed all my local code changes, limiting it only to translation. And I based this PR on the latest commit.

And I fixed some errors, some might still have slipped through.

@cvfosammmm
Copy link
Owner

Thanks. Is it still WIP?

@LyesSaadi LyesSaadi changed the title WIP: Adding French translations Adding French translations May 21, 2020
@LyesSaadi
Copy link
Contributor Author

I just forgot the edit the title! It no longer is WIP.

@cvfosammmm
Copy link
Owner

cvfosammmm commented May 31, 2020

Is there a shorter word for "warning" and "badbox" maybe?

@LyesSaadi LyesSaadi closed this May 31, 2020
@LyesSaadi
Copy link
Contributor Author

LyesSaadi commented May 31, 2020

Wow, so I closed the PR by accident, sorry for that (I restarted Firefox while writing the comment, and I think somehow GitHub interpreted that as close the PR and send the unfinished comment)!

@LyesSaadi LyesSaadi reopened this May 31, 2020
@LyesSaadi
Copy link
Contributor Author

For "warning" there's "alerte". For "badbox", "débordement" isn't a good translation, but I cannot find any better... A good translation would be "problème de mise en page" but it is way too long...

But after some thinking, I'll keep the English term badbox like in other translations :)!

@cvfosammmm
Copy link
Owner

"alerte" and "badbox" are fine.

Copy link
Contributor

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker of French.

po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved

#: setzer/workspace/sidebar/sidebar.py:49
msgid "Misc. Math"
msgstr "Divers symboles mathématiques"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be

Suggested change
msgstr "Divers symboles mathématiques"
msgstr "Symboles mathématiques divers"

but as I said I'm not a native speaker. Same below: Symboles divers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are valid ! But, I do prefer "Divers symboles" over "Symboles divers".

po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
po/fr.po Outdated Show resolved Hide resolved
@LyesSaadi
Copy link
Contributor Author

Thank you a lot for this review ❤️ ! This was my first try at translating a software, and, it's quite hard 😛. I'll reread my entire translation to fix any other grammar errors I might catch.

Unfortunately, until the 3rd of September, I'm quite busy, so I don't think I'll have a good translation until then.

I really wanted a French-speaking reviewer to review the translation, and I can't thank you more for finding those errors 😁 !

@LyesSaadi LyesSaadi changed the title Adding French translations [WIP] Adding French translations Sep 16, 2020
@oscfdezdz
Copy link
Contributor

oscfdezdz commented Jun 14, 2023

Hi @LyesSaadi, is this still WIP? We are integrating Weblate and would like to add your contribution through it, is that okay? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants