update ncruces driver #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ncruces, results are updated now. |
|
Oh, thanks! This shouldn't have changed results much (except on macOS) and it didn't. Great! More cgo competition, yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: thanks again, also for running your numbers again!
Second, I won't be doing this for every point update: I don't want to waste your time.
This PR does not (should not) affect benchmark numbers in any significant way.
I'm updating because again your code helped me detect a defect in my driver (thanks!), this time macOS specific, affecting only the large workloads.
This workload could (momentarily) need orders of magnitude (100s of GB) more disk space than actually required.
This was due to my implementation of
fallocatefor macOS, which I ported from mozilla. The buggy code is in Gists, StackOverflow answers, KDE source code, has been independently ported to other languages multiple times over.Hard to believe it's wrong, but a new unit test demonstrates it is.