Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MOSEK parameter setting #60

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fix MOSEK parameter setting #60

merged 1 commit into from
Dec 3, 2019

Conversation

aszekMosek
Copy link
Contributor

This is inspired by https://stackoverflow.com/questions/59040539/parameter-to-create-mosek-feasibility-report-with-cvxr. It fixes and simplifies MOSEK parameter settings through CVXR.

The change in line 36 fixes an actual bug which made it impossible to set MOSEK parameters at all.

The rewrite of _handle_mosek_params adapts it better to the argument types one can expect from R, removing the unnecessary parts originating from CVXPY but impossible to reach from R, and accounting for the fact that integers are doubles unless explicitly told not to. Examples are given in the comment to that method.

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   67.37%   67.37%           
=======================================
  Files          40       40           
  Lines        4705     4705           
=======================================
  Hits         3170     3170           
  Misses       1535     1535

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8bd7e4...3f20e3b. Read the comment docs.

Copy link
Collaborator

@bnaras bnaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This PR looks correct to me and I will merge it as soon as I can. However, just fyi, the version 1.0 branch does away with this (stop-gap) approach and uses native R packages.

@bnaras bnaras merged commit e3a2e35 into cvxgrp:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants