Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopfcn problem in tfocs_iterate.m #9

Closed
bradicator opened this issue Aug 22, 2017 · 1 comment
Closed

stopfcn problem in tfocs_iterate.m #9

bradicator opened this issue Aug 22, 2017 · 1 comment

Comments

@bradicator
Copy link

TFOCS v1.4
MATLAB version 9.0 (R2016a) on MACI64

Hi, in v1.4 and the current version on github, in file tfocs_iterate.m, line 85,
if isa(stopFcn,'function_handle') % added Oct 27 '14 is wrong. The reason is because by the design in tfocs_initialize.m, stopFcn is a cell containing function_handle rather than function_handle itself. The fix is
if isa(stopFcn{err_j},'function_handle'). One does not need to run the program to verify this; reading the context of this line is convincing enough. The consequence of this bug is that user defined stop functions never run...

Best,
Brad

@stephenbeckr
Copy link
Collaborator

You're right, good catch. Thanks! Just pushed the fix to github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants