Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer/composer version constraint to support Composer 2 #3

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Update composer/composer version constraint to support Composer 2 #3

merged 1 commit into from
Jul 24, 2020

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Apr 14, 2020

Updates the composer.jsons composer/composer version to allow composer v2 as well.

Related to cweagans/composer-patches#309.

Thank you.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b532b0f on Ayesh:composer2 into 064b8d8 on cweagans:master.

@cweagans
Copy link
Owner

Looking at it, I'm not sure this repo needs a composer version constraint at all. What do you think?

@Ayesh
Copy link
Contributor Author

Ayesh commented Apr 14, 2020

For the API compatibility, I think it's good to have a version set in. But it doesn't has to be composer/composer. We can perhaps pin to composer-api-version ^1 || ^2`?

As far as I remember, older PHP versions didn't care if the traits match the interface, but recent versions do. So if composer were to introduce a new version with API changes, this trait will break backwards compatibility. So I think it's good to have a version locked it just to be sure.

@cweagans cweagans merged commit 2ef48f3 into cweagans:master Jul 24, 2020
@staabm
Copy link

staabm commented Sep 23, 2020

to use composer-patches with composer v2 - which was added with cweagans/composer-patches#309 - we would also need a new release of this package, with the merged changes.

@Kocal
Copy link

Kocal commented Oct 30, 2020

Hi, is there any news about tagging a new release?
ping @cweagans
Thanks!

@tristanbes
Copy link

All PaaS upgraded their composer to version 2, hence the "emmergency" there :) @cweagans

@cweagans
Copy link
Owner

You should definitely not be using any version of composer patches that depends on this plugin. Use 1.7.0.

@Kocal
Copy link

Kocal commented Oct 30, 2020

Oh you're right, we were looking at master branch.
Btw why the latest tag does not require this plugin but the master branch "re-introduce" it? That's weird no? 🤔

@cweagans
Copy link
Owner

1.x is the current stable release series and is on the 1.x branch that split off from master a while back . Master is 2.x. :)

@Kocal
Copy link

Kocal commented Oct 30, 2020

Oh alright. Thanks for you explanation! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants