Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named #152

Merged
merged 4 commits into from
Mar 27, 2021
Merged

Named #152

merged 4 commits into from
Mar 27, 2021

Conversation

butuzov
Copy link
Contributor

@butuzov butuzov commented Mar 15, 2021

Resolves #148

@googlebot googlebot added the cla: yes Contributor signed Google CLA label Mar 15, 2021
@butuzov butuzov mentioned this pull request Mar 15, 2021
Closed
@butuzov
feature(named): Table Data as map (aka named)
605ed62 
* added `named` arguments to produce map instead of the slice with
  names as keys
* help records updated (readme and main.go)
@butuzov butuzov mentioned this pull request Mar 23, 2021
Closed
@butuzov
dev: adding tests
f0739f2 
minor tests adjustments
@coveralls
Copy link

coveralls commented Mar 26, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 95.619% when pulling 5fd5972 on butuzov:named into d408325 on cweill:develop.

@butuzov
Copy link
Contributor Author

butuzov commented Mar 26, 2021 •
edited
Loading

Hi @cweill, can you review, please?

In addition to original code and named implementation:

cweill
cweill approved these changes Mar 27, 2021
View reviewed changes
Copy link
Owner

@cweill cweill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@butuzov
Copy link
Contributor Author

butuzov commented Mar 27, 2021

@cweill will you merge it? =)

cweill
cweill requested changes Mar 27, 2021
View reviewed changes
gotests_test.go Outdated Show resolved Hide resolved
@cweill
Copy link
Owner

cweill commented Mar 27, 2021

@butuzov I left one comment I missed last night about tests when named=off being unnecessary (because named is off by default).

Please take a look, and I'll try to merge ASAP.

@butuzov
tests: some of the tests (named=off) removed
5fd5972 
As this functionality most probably already covered.
@butuzov
Copy link
Contributor Author

butuzov commented Mar 27, 2021

done

@cweill cweill merged commit d503102 into cweill:develop Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweill cweill cweill approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor signed Google CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having tests as map vs slice
4 participants
@butuzov @coveralls @cweill @googlebot