Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config.json needs to be a GameObject, and work without the config file #62

Closed
jackjansen opened this issue Jan 17, 2023 · 2 comments
Closed

Config.json needs to be a GameObject, and work without the config file #62

jackjansen opened this issue Jan 17, 2023 · 2 comments
Assignees
@jackjansen

Comments

@jackjansen
Copy link
Collaborator

Required for #18 but would also be generally useful. Probably a GameObject that makes itself persistent. And if you try to use the Instance if it hasn't been instantiated yet it'll give an error message explaining you should add it to the scene.
@jackjansen jackjansen self-assigned this Jan 17, 2023
@jackjansen
Copy link
Collaborator Author

Half way done. I will now merge into the various branches and then do the next steps:

  • Moving various settings out of VRTConfig to other places (basically anything that is ever changed on the fly)
  • Make the scenario-to-scene dictionary a MonoBehaviour too, and fill all entries.

jackjansen added a commit that referenced this issue Jan 19, 2023
@jackjansen
Issue #62 Make configuration object a component so config.json become…
1aba28d 
…s optional. (#63)

* Renamed Config to VRTConfig

* VRTConfig is now a MonoBehaviour. It is a component on VRTInitializer, which adds itself to DontDestroyOnLoad.

* Got rid of many outdated configuration parameters.

* Fixed VRTConfig references that were too early, or too late.

* PilotRegistry is now a component, and it contains the same set of names used in the orchestrator.

* Updated documentation (indeed! :-)

* Copied default vaules from config.json (so it is now technically no longer needed).

* Tweaks.
@jackjansen
Copy link
Collaborator Author

Implemented and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackjansen jackjansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackjansen