Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0421/change-tmp-shadow] 一時矢印色変更時に影矢印も色変更するよう見直し #1070

Merged
merged 1 commit into from
May 4, 2021

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented May 4, 2021

🔨 変更内容 / Details of Changes

  1. 一時矢印色変更時に影矢印も色変更するよう見直しました。
  2. 影矢印取得処理を集約しました。
  3. changeTmpColor関数をfor文の外に移動しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. 一時矢印色変更時に影矢印の色は追随できていなかったため。
  2. 影矢印取得処理がほぼ同じ処理のため。
  3. 毎回定義し直す必要が無いため。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@codeclimate
Copy link

codeclimate bot commented May 4, 2021

Code Climate has analyzed commit e6265a2 and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle merged commit 25d4dce into develop May 4, 2021
@cwtickle cwtickle deleted the feature/0421-change-tmp-shadow branch May 5, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant