Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FileStream and iterators to read from files #31

Merged
merged 4 commits into from
Oct 24, 2017
Merged

Implement FileStream and iterators to read from files #31

merged 4 commits into from
Oct 24, 2017

Conversation

Coolnesss
Copy link
Collaborator

@Coolnesss Coolnesss commented Oct 24, 2017 •
edited
Loading

  • File reading works by byte and by line

Addresses #21

@Coolnesss Coolnesss requested a review from emlai October 24, 2017 17:51
emlai
emlai reviewed Oct 24, 2017
View reviewed changes
stdlib/io/FileStream.delta Outdated
file = fopen(String(filename).cString(), "r");

if (file == null) {
print("lol");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Nice error handling.

@Coolnesss Coolnesss mentioned this pull request Oct 24, 2017
Closed
2 tasks
@emlai emlai merged commit 016e8ec into cx-language:master Oct 24, 2017
@emlai emlai deleted the fileio branch October 24, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlai emlai emlai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coolnesss @emlai