Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the directory structure of gltf-test #9

Closed
cx20 opened this issue Jan 27, 2017 · 4 comments
Closed

Consider the directory structure of gltf-test #9

cx20 opened this issue Jan 27, 2017 · 4 comments

Comments

@cx20
Copy link
Owner

cx20 commented Jan 27, 2017

I moved the following discussion to this Issue.
CesiumGS/cesium#4808 (comment)

I basically want to test using the model obtained from the Khronos official sample site. (https://github.com/KhronosGroup/glTF-Sample-Models)
However, I have to consider how to structure the folder. I am thinking about the next two plans.

Plan-1) Version control is done like Three.js
https://github.com/cx20/gltf-test/tree/r1/sampleModels ... glTF 1.0 (Old version)
https://github.com/cx20/gltf-test/tree/r1/tutorialModels ... glTF 1.1 (Old version)
https://github.com/cx20/gltf-test/tree/master/sampleModels ... glTF 2.0 (Latest version)
https://github.com/cx20/gltf-test/tree/master/tutorialModels ... glTF 2.0 (Latest version)

Plan-2) Create version folder by category
https://github.com/cx20/gltf-test/tree/master/sampleModels/1.0 ... glTF 1.0
https://github.com/cx20/gltf-test/tree/master/sampleModels/2.0 ... glTF 2.0
https://github.com/cx20/gltf-test/tree/master/tutorialModels/1.1 ... glTF 1.1
https://github.com/cx20/gltf-test/tree/master/tutorialModels/2.0 ... glTF 2.0

Plan-3) Using github submodule

Please tell me if you have any other good ideas :-)

@pjcozzi
Copy link

pjcozzi commented Jan 31, 2017

It's your call, but I find that a lot of users get tripped up by submodules.

@kyasbal
Copy link
Contributor

kyasbal commented Jan 31, 2017

I don't recomment submodules also.

@cx20
Copy link
Owner Author

cx20 commented Jan 31, 2017

Thank you both for your advice. Since I am not familiar with git, I need to investigate submodule.
However, I don't think I will use submodule this time.

@cx20
Copy link
Owner Author

cx20 commented Feb 5, 2017

I decided to run Plan 5 tentatively.

Plan-5) Create glTF 2.0 branch
https://github.com/cx20/gltf-test/tree/2.0/sampleModels
https://github.com/cx20/gltf-test/tree/2.0/tutorialModels

@cx20 cx20 closed this as completed Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants