New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reduce and reduceRight to work on falsy values #15

Closed

davidnurkkala wants to merge 1 commit into cxmeel:main from davidnurkkala:fix-falsy-reduce-problem

davidnurkkala commented Aug 24, 2023 •

edited

Loading

Had a problem where I was trying to detect state change by using an array of results returned by setter functions. Essentially,

if Sift.Array.reduce(results :: {boolean}, function(accumulator, changed)
  return accumulator or changed
end, false) then
  -- something changed
end

Found out that it assumed the initial value to not be a truthy value. Changed it to compare directly to nil instead.


          Allow reduce and reduceRight to work on falsy values

b0808ff

Owner

cxmeel commented Aug 29, 2023

Merged into main

cxmeel closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment