Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict style to the IA #22

Closed
cyChop opened this issue Mar 20, 2016 · 4 comments
Closed

Restrict style to the IA #22

cyChop opened this issue Mar 20, 2016 · 4 comments
Assignees

Comments

@cyChop
Copy link
Owner

cyChop commented Mar 20, 2016

Make sure the style does not apply outside the IA by using a root container.

This messes with the building of the stylesheet, though.

@cyChop cyChop added the bug label Mar 20, 2016
@cyChop cyChop modified the milestone: 1.0.0 Apr 2, 2016
@cyChop cyChop modified the milestones: 0.4.0, 1.0.0, 0.3.0 Apr 14, 2016
@cyChop cyChop added the ready label Apr 14, 2016
@cyChop cyChop self-assigned this Apr 14, 2016
@cyChop cyChop added in progress and removed ready labels Apr 17, 2016
cyChop added a commit that referenced this issue Apr 17, 2016
- The problem I had was that some styles were applied to the body, I had to extend it... Stupid not thinking of it before
@cyChop cyChop closed this as completed Apr 17, 2016
@cyChop
Copy link
Owner Author

cyChop commented May 2, 2016

Not done...

@cyChop cyChop reopened this May 2, 2016
@cyChop cyChop modified the milestones: 1.0.0, 0.3.0 Jul 26, 2016
@cyChop cyChop added the ready label Jul 26, 2016
@cyChop
Copy link
Owner Author

cyChop commented Aug 14, 2016

Tried moving @import "bootstrap"; inside .beverages-container but this causes the style to break.

The stylesheet causing the style to break is node_modules/bootstrap/scss/reboot. This needs to be imported at the root of the stylesheet.

This is obviously a problem as it may break the main page style. Moving out of bootstrap would have other consequences we may not wish to face right now.

If no solution can be found, this plugin should be published with a warning that it may break the page's style, but it's not clean.

For any following on this topic, the following works (for the plugin at least):

@import "variables";
//@import "bootstrap";

// Core variables and mixins
@import "node_modules/bootstrap/scss/variables";
@import "node_modules/bootstrap/scss/mixins";

// Reset and dependencies
@import "node_modules/bootstrap/scss/normalize";
@import "node_modules/bootstrap/scss/print";

// Core CSS
@import "node_modules/bootstrap/scss/reboot";

.beverages-container {
  @import "node_modules/bootstrap/scss/type";
  @import "node_modules/bootstrap/scss/grid";
  @import "node_modules/bootstrap/scss/buttons";

  // Components
  @import "node_modules/bootstrap/scss/animation";
  @import "node_modules/bootstrap/scss/dropdown";
  @import "node_modules/bootstrap/scss/button-group";
  @import "node_modules/bootstrap/scss/labels";
  @import "node_modules/bootstrap/scss/alert";

  // Components w/ JavaScript
  @import "node_modules/bootstrap/scss/tooltip";

  // Utility classes
  @import "node_modules/bootstrap/scss/utilities";
  @import "node_modules/bootstrap/scss/utilities-responsive";

  @extend .container-fluid;
  padding: 7px;
   // ...
}

@cyChop cyChop added ready and removed in progress labels Aug 14, 2016
@cyChop cyChop removed this from the 1.0.0 milestone Aug 16, 2016
@cyChop cyChop removed the ready label Aug 16, 2016
@cyChop
Copy link
Owner Author

cyChop commented Aug 16, 2016

This will remain a known and open bug for now.

@cyChop
Copy link
Owner Author

cyChop commented Nov 9, 2016

How about dropping Bootstrap and do everything from start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant