Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 fixes (maintains python2 compatibility) #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

temetski
Copy link

@temetski temetski commented Sep 23, 2021

After some digging, I think I may have resolved the segfault issue on Python>3.6.1 on MacOS (see #179). It has to do with

  1. Linking of necessary python libraries to swig
  2. Deprecated swig_link_libraries (see https://cmake.org/cmake/help/latest/module/UseSWIG.html in conjunction with https://cmake.org/cmake/help/latest/policy/CMP0078.html)
  3. Deprecated PythonInterp and PythonLibs. Best way to pass libraries to target_link_libraries is using Python::Module of FindPython

This PR changes PythonInterp and PythonLibs to prefer FindPython, which detects your python library (python 2 or 3) and sets up CMAKE appropriately. It then deprecates swig_link_libraries in favor of target_link_libraries for CMAKE versions 3.13 and above.
Additionally, assuming the presence of conda indicates preference for the python conda version, added

set(Python_FIND_STRATEGY LOCATION) # might want to prefer conda over system python

following suggestions in https://gitlab.kitware.com/cmake/cmake/-/issues/21322. This addresses issues when conda's python version is less than that of the system python install.

The above changes seem to still be compatible with ubuntu-based python 2 and python 3 installs, while resolving the segfault issues encountered in the python3 install of fmm on MacOS.

CI testing might have to be changed a bit to test for python3 since python defaults to the python 2 install in most systems.

Edit: It seems most of your build configs for testing rely on ubuntu 16.04, which uses an old version of CMAKE. To maintain compatibility with the old and new CMAKE versions, we can use PythonInterp and PythonLibs for CMAKE<3.13, while using FindPython for newer CMAKE versions.

@cyang-kth
Copy link
Owner

Thanks for your contribution. I will have a look at my spare time.

@Ianc98
Copy link

Ianc98 commented Jul 31, 2023

Some methods need replacing too, such as'has_key'

@rderollepot
Copy link

Thank you for this PR, helped a lot!

Copy link

@AlessandroGianfelici AlessandroGianfelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes the example work with python 3.x without breaking the compatibility with python 2.x. It's a small fix that could be merged

Copy link

@AlessandroGianfelici AlessandroGianfelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everithing works with python 2.x and 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants