Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Integration Tests: Roles and Resources #82

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

john-odonnell
Copy link
Contributor

Desired Outcome

Fix integration tests.

Implemented Changes

  1. Include admin user in Resources API test case. Admin users now have a corresponding resource: Create a resource for the account admin user conjur#2757
  2. Update test cases for Roles API. Roles API endpoints now return 404 when the caller has insufficient privilege: Add Role and Resource lookup to Roles Controller conjur#2755

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Admin users now have a corresponding resource:
cyberark/conjur#2757
Roles API endpoints now return 404 when the caller has
insufficient privilege: cyberark/conjur#2755
@john-odonnell john-odonnell requested a review from a team as a code owner April 24, 2023 22:51
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-odonnell john-odonnell merged commit 3c98b05 into main Apr 25, 2023
@john-odonnell john-odonnell deleted the role-tests branch April 25, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants