-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONYX-13637: Nested claims input validation #2403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
app/domain/authentication/authn_jwt/input_validation/validate_claim_name.rb
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/parse_claim_aliases_spec.rb
Show resolved
Hide resolved
app/domain/authentication/authn_jwt/input_validation/parse_claim_aliases.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/parse_claim_aliases_spec.rb
Show resolved
Hide resolved
@semyon-estrin please pay your attention on broken cucumber tests |
app/domain/authentication/authn_jwt/input_validation/parse_claim_aliases.rb
Show resolved
Hide resolved
Code Climate has analyzed commit 4a54cec and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (-0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
spec/app/domain/authentication/authn-jwt/input_validation/validate_claim_name_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Desired Outcome
Verify that invalid characters validation is enforced in Claim Aliases.
Implemented Changes
name:value
Added additinal validation on Claim Alias
name
to not allow use of'/'
character. (Claim Aliasvalue
still can use'/'
)Connected Issue/Story
Resolves CyberArk internal issue link: ONYX-13637
Changelog
CHANGELOG update
Test coverage
Documentation
README
s) were updated in this PRBehavior
Security