Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONYX-13637: Nested claims input validation #2403

Merged
merged 10 commits into from
Nov 2, 2021

Conversation

semyon-estrin
Copy link
Contributor

Desired Outcome

Verify that invalid characters validation is enforced in Claim Aliases.

Implemented Changes

Connected Issue/Story

Resolves CyberArk internal issue link: ONYX-13637

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit tests to go with the code.
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation.

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin requested a review from a team as a code owner November 1, 2021 18:30
Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@sashaCher
Copy link
Contributor

@semyon-estrin please pay your attention on broken cucumber tests

@codeclimate
Copy link

codeclimate bot commented Nov 2, 2021

Code Climate has analyzed commit 4a54cec and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.8% (-0.1% change).

View more on Code Climate.

Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

sashaCher
sashaCher previously approved these changes Nov 2, 2021
Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants