Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build secretless-broker for Apple silicon #1456

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Build secretless-broker for Apple silicon #1456

merged 1 commit into from
Mar 3, 2022

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Mar 2, 2022

Desired Outcome

GoReleaser builds Windows, Linux and Darwin-amd64 images but does
not build for the new Apple M1 hardware.

See cyberark/summon#217

Implemented Changes

Connected Issue/Story

Needed by cyberark/homebrew-tools#41

Definition of Done

  • Goreleaser generates builds for Apple silicon

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier marked this pull request as ready for review March 2, 2022 22:01
@rpothier rpothier requested a review from a team as a code owner March 2, 2022 22:01
@rpothier rpothier marked this pull request as draft March 3, 2022 14:34
@rpothier rpothier marked this pull request as ready for review March 3, 2022 15:08
@codeclimate
Copy link

codeclimate bot commented Mar 3, 2022

Code Climate has analyzed commit 4c3a93a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 34.9%.

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants