Update containerd and docker packages #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -10,6 +10,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| - Support for building on Apple M1 hardware. | |||
| [cyberark/secretless-broker#1456](https://github.com/cyberark/secretless-broker/pull/1456) | |||
|
|
|||
| ### Security | |||
| - Updated github.com/containerd/containerd to resolve CVE-2022-23648 | |||
There was a problem hiding this comment.
Lists should be surrounded by blank lines
|
Code Climate has analyzed commit c2a0f7e and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 34.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Dependabot has flagged 3 issues in Secretless modules:
CVE-2022-23648: Insecure handling of image volumes in containerd CRI plugin (High severity)
CVE-2015-3627: Symlink attack in libcontainer and docker engine (Medium severity)
GHSA-qq97-vm5h-rrhg: OCI Manifest Type Confusion
It looks like the affected modules are only indirect dependencies or used in test code, but we should upgrade them. Some of the updates seem to cross major version boundaries, so this is likely more than just version bumps.
To fix these, we need to get:
github.com/containerd/containerd to 1.6.1, 1.5.10, or 1.4.13 or later
github.com/docker/docker to 1.6.1 or later
github.com/docker/distribution to 2.8.0 or later (or if we're using the main branch, to the commit after distribution/distribution@b59a6f8)
This includes any indirect references back to these libraries if possible. (Go.sum should contain no references to vulnerable versions. If that's not possible, we need to document which modules are pulling in old versions so we can watch for updates to them or replace those modules with more up-to-date alternatives.)
Implemented Changes
Connected Issue/Story
Resolves #1420
CyberArk internal issue link: CONJSE-1284
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security