-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1467
Update dependencies #1467
Conversation
CHANGELOG.md
Outdated
## [1.7.13] - 2022-06-14 | ||
### Changed | ||
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2, | ||
github.com/go-sql-driver/mysql -> 1.6.0, github/lib/pq -> 1.10.6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
CHANGELOG.md
Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.7.13] - 2022-06-14 | |||
### Changed | |||
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line length
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.7.13] - 2022-06-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headers should be surrounded by blank lines
CHANGELOG.md
Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.7.13] - 2022-06-14 | |||
### Changed | |||
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
fd45b8e
to
8f7eeed
Compare
CHANGELOG.md
Outdated
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.7.13] - 2022-06-14 | |||
### Changed | |||
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
This comment was marked as outdated.
This comment was marked as outdated.
|
||
## [1.7.13] - 2022-06-14 | ||
### Changed | ||
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod and add replace statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line length
@@ -5,6 +5,15 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
### Changed | |||
- Nothing should go in this section, please add to the latest unreleased version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
|
||
## [1.7.13] - 2022-06-14 | ||
### Changed | ||
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod and add replace statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
3b32731
to
1a9c365
Compare
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
1a9c365
to
d81ebb6
Compare
Code Climate has analyzed commit d81ebb6 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Desired Outcome
Remove as many dependencies on gopkg.in/yaml.v3 older than 3.0.1 as possible.
Implemented Changes
Updates direct dependencies in bin/juxtaposer/go.mod and go.mod.
Connected Issue/Story
CyberArk internal issue: CONJSE-1376
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security