Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1467

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Update dependencies #1467

merged 3 commits into from
Jun 28, 2022

Conversation

andytinkham
Copy link
Contributor

Desired Outcome

Remove as many dependencies on gopkg.in/yaml.v3 older than 3.0.1 as possible.

Implemented Changes

Updates direct dependencies in bin/juxtaposer/go.mod and go.mod.

Connected Issue/Story

CyberArk internal issue: CONJSE-1376

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner June 15, 2022 18:55
CHANGELOG.md Outdated
## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2,
github.com/go-sql-driver/mysql -> 1.6.0, github/lib/pq -> 1.10.6,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

CHANGELOG.md Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.7.13] - 2022-06-14
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers should be surrounded by blank lines

CHANGELOG.md Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod (github.com/denisenkom/go-mssqldb -> 0.12.2,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

CHANGELOG.md Outdated
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@andytinkham

This comment was marked as outdated.


## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod and add replace statements
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

@@ -5,6 +5,15 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Nothing should go in this section, please add to the latest unreleased version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines


## [1.7.13] - 2022-06-14
### Changed
- Updated direct dependencies in bin/juxtaposer/go.mod and in go.mod and add replace statements
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
@codeclimate
Copy link

codeclimate bot commented Jun 28, 2022

Code Climate has analyzed commit d81ebb6 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants