Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Golang to 1.19; Upgrade container base images #1491

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 27, 2023

Desired Outcome

Resolve dependency vulnerabilities reported by Snyk.

Implemented Changes

  • Updated Golang version to 1.19
    • This includes updating command syntax from go get to go install
  • Update outdated container base images

Connected Issue/Story

CyberArk internal issue ID: CONJSE-1669

Definition of Done

  • Snyk reports fewer issues in this repository

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Mar 27, 2023
@szh szh force-pushed the snyk-issues branch 7 times, most recently from f37aed1 to 82465c7 Compare March 27, 2023 14:41
@szh
Copy link
Contributor Author

szh commented Mar 27, 2023

Waiting on #1490 to be merged since that will take care of some of the issues

@szh szh force-pushed the snyk-issues branch 2 times, most recently from de8cb5d to e223d0b Compare March 28, 2023 20:45
## [1.7.17] - 2023-03-27

### Changed
- Updated Go version to 1.19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023

Code Climate has analyzed commit e619726 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.7% (0.0% change).

View more on Code Climate.

@szh szh marked this pull request as ready for review March 29, 2023 12:49
@szh szh requested a review from a team as a code owner March 29, 2023 12:49
@szh szh requested a review from andytinkham March 29, 2023 12:49
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks, @szh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants