Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move import_private command to keys subcomand #152

Closed
mastercyb opened this issue Jan 5, 2019 · 4 comments
Closed

Move import_private command to keys subcomand #152

mastercyb opened this issue Jan 5, 2019 · 4 comments
Assignees
@arturalbov
Labels
Code: CLI Type: Bug Something isn't working
Milestone
Sprint 26

Comments

@mastercyb
Copy link
Member

Overview

cyberdcli keys --help do not shows import_private command.

Task description

Add keys import_private command description to cli help
@mastercyb mastercyb added the Type: Bug Something isn't working label Jan 5, 2019
@hleb-albau
Copy link
Contributor

I would rather rename this to Move import_private command to keys subcomand.

@mastercyb mastercyb changed the title Add import_private command to help description Move import_private command to keys subcomand Jan 5, 2019
@mastercyb
Copy link
Member Author

mastercyb commented Jan 5, 2019 •
edited
Loading

IMHO it is better to add option to keys add command. Current implementation is confusing

@hleb-albau
Copy link
Contributor

Not possible. It is closed, unpluguble peace of code from cosmos :(. That why we create own separate command.

@arturalbov
Copy link
Contributor

arturalbov commented Jan 7, 2019 •
edited
Loading

It's possible.
Syntax will be cyberdcli keys add import_private <name>
To see help you should type cyberdcli keys add --help

arturalbov added a commit that referenced this issue Jan 7, 2019
@arturalbov
#152 Move import_private command to keys subcomand
d174777
arturalbov added a commit that referenced this issue Jan 7, 2019
@arturalbov
#152 Move import_private command to keys subcomand
3077565
hleb-albau pushed a commit that referenced this issue Jan 9, 2019
@arturalbov @hleb-albau
#152 Move import_private command to keys subcomand
d2bfbe0
hleb-albau added a commit that referenced this issue Jan 9, 2019
@hleb-albau
Update docs according to #152
9e96e25
@hleb-albau hleb-albau added this to the Sprint 26 milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arturalbov arturalbov

Labels
Code: CLI Type: Bug Something isn't working
Projects
None yet
Milestone
Sprint 26
Development

No branches or pull requests
3 participants
@mastercyb @hleb-albau @arturalbov