-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed drop-hover position on first column last thought in table view #2125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For #1887, the drop hover needs to be positioned with its left edge flush with the left edge of col1, regardless of the length of thoughts in col1. In this example with longer thoughts in col1, the drop hover is too far to the right:
- a
- =view
- Table
- =pin
- true
- Boston
- c
- Denver
- e
- x
Please add a snapshot test for each issue as well. Thanks!
I think I should make a separate PR for #1886 if the solution is good for that. |
Yes, a separate PR for each issue is preferred. Please make sure to describe the cause of the problem as well once you identify. That will help determine the appropriateness of the solution. |
One thing I want to ask is that in the table view initially the columns are too far to the left until x is dragged after d/denver, then the columns shifts to right, my guess is that the drop-hover is rendering to the right before the drag, shouldn't the columns already be in the position the columns move to after drag? |
Hmmm good point. That’s a bug in the table view. We may want to wait until that’s fixed to confirm if this is still an issue. |
80019f7
to
10b9d7c
Compare
@Zubair286, it appears that this issue has been resolved (by #2175?): Screen.Recording.2024-09-18.at.12.53.47.AM.movCan this pull request be closed, or does more need to be done? |
@trevinhofmann Yes, this pull request can be closed. |
#1887