-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to raml-1-parser #177
Comments
raml-1-parser written in typescript. abao written in coffeescript. |
@coltonlw, can you fix tests and make pull request? |
Hey guys, any update on this? I'm interested in this as well! Thanks @coltonlw |
@galk-in the transpilation of For reference:
raml-js-parser-2 just transpiles down via
I mentioned this in the other thread, but if there is enough support, I wouldn't mind building a halfway measure with ES6. You'd find fewer and fewer people knowledgeable in CoffeeScript that can help maintain a project targeting a technology that is so new(RAML) as time progresses. |
@oshalygin I agree with your proposed JavaScript instead of CoffeScript / TypeScript approach. It may not perhaps be the best overall approach in the long term, but RAML 1.0 won't get enough traction without these tools working. |
@janaaronlee This Saturday/Sunday I plan to have a working version(stable). I don't mind helping with a bit of CoffeeScript on abao but that may be limited until I get the rest of the tooling together with the unified docs. A better solution may just be a module that abao can consume to support RAML 1.0 and have a command line arg(or better yet, read the version via |
Abao should be upgraded to use raml-js-parser-2
The new parser supports RAML 1.0, so upgrading to it is a major step towards RAML 1.0 support in abao
The mulesoft api-workbench atom add-on uses raml-js-parser-2. The new parser is capable of resolving jsonschema $ref's, which is how the api-workbench does it. This will keep $ref parsing behavior in abao consistent with mulesoft RAML tooling, and allow resolving $ref's that are local filesystem paths.
I have a feature branch where I upgraded abao to use raml-js-parser-2. My changes for abao to use raml-js-parser-2 are mostly functional in a prototype quality state, the last thing is actually getting the new parser to resolve the $ref's. I am working to figure this out and will keep you updated. Still need to fix some tests, but I can run my feature branch against our RAML spec and aside from the $ref resolution error it appears to work.
raml-org/raml-js-parser-2#481
My abao feature branch for using raml-js-parser-2 (tests still need updating, $ref parsing waiting on response from raml-js-parser-2 project)
master...flywheel-io:raml-1-parser
https://github.com/raml-org/raml-js-parser-2
The text was updated successfully, but these errors were encountered: