chore: introduce conversion-gen to generate conversion functions #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #128 (review), it seems like we soon want to add another API version of
SubNamespace. To avoid hand-writing error-prone code to convert similar/identical API versions of resources, I think it's time to introduceconversion-gen- the tool used by upstream Kubernetes to generate efficient conversion functions.Since we dramatically change the status subresource between v1 and v2 of SubNamespace, it does not add significant value right now. But when introducing
v2beta1and/orv2versions it makes more sense.