add reboot queue backoff reset command #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YZ775
force-pushed
the
add-reboot-queue-backoff-reset
branch
4 times, most recently
from
5d5e89e
to
78cd6ef
Compare
YZ775
force-pushed
the
add-reboot-queue-backoff-reset
branch
from
78cd6ef
to
7dbab97
Compare
yokaze
requested changes
Oct 25, 2023
docs/ckecli.md
Outdated
| ### `ckecli reboot-queue reset-backoff` | ||
|
|
||
| Reset `drain_backoff_count` and `drain_backoff_expire` of the entries in reboot queue. | ||
| Resetting these values allows CKE to try draining nodes again immediately. |
There was a problem hiding this comment.
- It is better to use a verb that guarantees the action being actually done, instead of using allow.
- This command cause the retry of entire reboot sequence, not only draining.
- Try V-ing means to check the result of the action. Use "try to" if it may fail.
Suggested change
| Resetting these values allows CKE to try draining nodes again immediately. | |
| Resetting these values makes CKE try to reboot nodes again immediately. |
There was a problem hiding this comment.
Thank you. I fixed it.
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
YZ775
force-pushed
the
add-reboot-queue-backoff-reset
branch
from
7dbab97
to
3b4af28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementation of following issue.
Signed-off-by: YZ775 yuzuki-mimura@cybozu.co.jp