Add stub HTTPS server for virtual BMC #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Certificate resouce Signed-off-by: dulltz <isrgnoe@gmail.com>
ymmt2005
reviewed
Dec 5, 2019
bmc.go
Outdated
Comment on lines
220
to
224
| go func() { | ||
| <-ctx.Done() | ||
| serv.Close() | ||
| }() | ||
| return nil |
There was a problem hiding this comment.
<-ctx.Done()
return serv.Close()
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
dulltz
changed the title
ymmt2005
requested review from
morimoto-cybozu
and removed request for
ymmt2005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing BMC reverse proxy server https://github.com/cybozu-go/neco-apps/pull/250, add stub HTTPS server for virtual BMC.
For each node, Placemat deploys HTTPS server listening
https://<BMC address>:443.If you want to enable this feature, prepare certificate files, then add the following options:
-bmc-cert=<path to cert file>-bmc-key=<path to key file>