fix: false positive of no-shadow rule for TypeScript

[a-takamin]

I have added code that avoids the "false positive" problem of the eslint/no-shadow rule for TypeScript code discussed in "typescript-eslint" issue below.

Please see this issue for more detailed information.
typescript-eslint/typescript-eslint#2483

[koba04]

@a-takamin
Thank you!
I have a question. why do we have to put the settings into the overrides section?
Is there any problems if we put the settings into the top rules section directly in lib/typescript.js rather than wrapping it with the overrides section?

• lib/typescript.js

"rules": {
  ...
  "no-shadow": "off",
  "@typescript-eslint/no-shadow": "error",
}

[a-takamin]

@koba04
Thank you for your comment.
You are right. My change is redundant, and we can put the setting into the top rules section directly.

I should change the content of the pull request. May I change this commit and use force push?

[a-takamin]

@koba04
Hello! I have deleted "overrides" section and pushed it.
I would appreciate if you could review the updated pull request. Thank you in advance!

[koba04]

@a-takamin Thank you! I left a comment.

[koba04]

Could you remove this change in this file?
This file should only include rules for React & TypeScript and the no-shadow rule is related to TypeScript.
We expect lib/react-typescript is used with lib/typescript, so we don't have to have this setting besides in lib/typescript.

We expect that lib/* is an internal library and presets/* is a public interface, so we don't intend lib/* is used directly in ESLint configs.

[a-takamin]

@koba04
Thanks for the review!
I am sorry for the lack of understanding. I understand the difference between lib/* and presets/*. I removed the changes in the file, and could you review it again please?

[koba04]

👍 Great work! Thank you!