-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of parameter in dc_block::operator= function #64
Conversation
Can you also 'fix' the docs? It's just a text file *.adoc |
Oh, please update to the latest develop and update the PR to fix the gcc build problem. |
I have changed it now but I have another question before I continue. The parameter is "dc_block::operator=(float y_)" but everywhere else you seem to be using "_y". Should I change this as well? I assume that you are using it to differentiate the parameter from the output value y. This is the case in the adoc as well. |
Oh good point! Please do! :-) Edit: Ah wait, no. I use Had a look at where in the documentation. Likewise, in those cases, it's better to just use Edit2: Oh, and indeed it is a member variable! It is not an artifact. |
Merged! Thank you! |
I didn’t change the y_ in the code. You closed just before I tried to push the latest. I only changed from bool to float in the declaration, the implementation and in the documentation of the dc_block operator = |
It's OK. I'll do it here. Many thanks! |
Done :-) |
This pull request addresses a type mismatch issue in the dc_block::operator= function.
In the current implementation, the operator= function is declared to take a bool parameter. However it should accept a float instead.
Change the bool parameter type in dc_block::operator= to float.