Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prefix parameter to Embedded #46

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Adding prefix parameter to Embedded #46

merged 3 commits into from
Jan 11, 2022

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 30, 2021 •
edited by roxblnfk
Loading

@msmakouz msmakouz marked this pull request as draft December 30, 2021 14:00
@roxblnfk roxblnfk added the type:feature New feature. label Dec 30, 2021
@roxblnfk roxblnfk linked an issue Dec 30, 2021 that may be closed by this pull request
💡 define a embeddable object prefix in the Embedded relation #47
Closed
@roxblnfk roxblnfk marked this pull request as ready for review January 11, 2022 11:54
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #46 (0f9d918) into 3.x (4e5cb3a) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x      #46      +/-   ##
============================================
+ Coverage     90.19%   90.38%   +0.18%     
- Complexity      232      236       +4     
============================================
  Files            32       32              
  Lines           561      572      +11     
============================================
+ Hits            506      517      +11     
  Misses           55       55
Impacted Files Coverage Δ
src/Annotation/Relation/Embedded.php 100.00% <100.00%> (ø)
src/Configurator.php 84.73% <100.00%> (+0.60%) ⬆️
src/Embeddings.php 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5cb3a...0f9d918. Read the comment docs.

@roxblnfk roxblnfk merged commit f6084f7 into cycle:3.x Jan 11, 2022
@roxblnfk roxblnfk mentioned this pull request Jan 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees
No one assigned
Labels
type:feature New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 define a embeddable object prefix in the Embedded relation
2 participants
@msmakouz @roxblnfk