Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generated fields #95

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Add support for generated fields #95

merged 6 commits into from
Feb 8, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Feb 6, 2024

What was changed

Added support for GENERATED_FIELDS in the schema, which will be in the next version of Cycle ORM

Checklist

@msmakouz msmakouz added the type:feature New feature. label Feb 6, 2024
@msmakouz msmakouz self-assigned this Feb 6, 2024
@roxblnfk roxblnfk mentioned this pull request Feb 8, 2024
7 tasks
src/Configurator.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5565329) 92.02% compared to head (feb91a2) 91.87%.

❗ Current head feb91a2 differs from pull request most recent head f603c11. Consider uploading reports for the commit f603c11 to get more accurate results

Files Patch % Lines
src/Configurator.php 85.71% 2 Missing ⚠️
src/Annotation/Generated.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                4.x      #95      +/-   ##
============================================
- Coverage     92.02%   91.87%   -0.15%     
- Complexity      296      310      +14     
============================================
  Files            37       38       +1     
  Lines           765      788      +23     
============================================
+ Hits            704      724      +20     
- Misses           61       64       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 7dad356 into 4.x Feb 8, 2024
9 checks passed
@roxblnfk roxblnfk deleted the feature/generated branch February 8, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants