Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IS_REPEATABLE attr, updating Psalm #11

Merged
merged 3 commits into from
May 19, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented May 9, 2023

  1. Added IS_REPEATABLE to all Uuid attributes. Fix Make attributes repeatable #9
  2. Updated Psalm to v5.11
  3. Added PHP 8.2 tests
  4. Added tests with annotations

@msmakouz msmakouz added the type:enhancement Enhancement. label May 9, 2023
@msmakouz msmakouz requested a review from roxblnfk May 9, 2023 10:50
@msmakouz msmakouz self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #11 (b04c518) into 1.x (95b63ba) will increase coverage by 46.47%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##                1.x      #11       +/-   ##
=============================================
+ Coverage     50.74%   97.22%   +46.47%     
- Complexity       54       61        +7     
=============================================
  Files            15       15               
  Lines           134      144       +10     
=============================================
+ Hits             68      140       +72     
+ Misses           66        4       -62     
Impacted Files Coverage Δ
src/Listener/Uuid1.php 100.00% <100.00%> (ø)
src/Listener/Uuid2.php 81.81% <100.00%> (+1.81%) ⬆️
src/Listener/Uuid3.php 100.00% <100.00%> (ø)
src/Listener/Uuid4.php 100.00% <100.00%> (ø)
src/Listener/Uuid5.php 100.00% <100.00%> (ø)
src/Listener/Uuid6.php 85.71% <100.00%> (+2.38%) ⬆️
src/Listener/Uuid7.php 100.00% <100.00%> (ø)
src/Uuid.php 100.00% <100.00%> (ø)
src/Uuid1.php 100.00% <100.00%> (ø)
src/Uuid2.php 94.11% <100.00%> (+94.11%) ⬆️
... and 5 more

@roxblnfk
Copy link
Member

WDYT should we add some option like generate to disable UUID autogeneration? In thisa case an UUID attribute will be used to just define a column of the needed type

src/Listener/Uuid1.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make attributes repeatable
2 participants