Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JTI filter by parent fields #405

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Mar 31, 2023

Closes #404

Also:

  • make Select::wherePK() more strict (you should use entity field name instead of columns)
  • fix method naming AbstractLoader::loadIerarchy() (deprecated and renamed to ::loadHierarchy())

@roxblnfk roxblnfk added type:enhancement Enhancement. type:feature New feature. labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #405 (9f52984) into 2.x (1b5841c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9f52984 differs from pull request most recent head 227c358. Consider uploading reports for the commit 227c358 to get more accurate results

@@            Coverage Diff            @@
##                2.x     #405   +/-   ##
=========================================
  Coverage     91.49%   91.50%           
- Complexity     1749     1752    +3     
=========================================
  Files           112      112           
  Lines          4447     4452    +5     
=========================================
+ Hits           4069     4074    +5     
  Misses          378      378           
Impacted Files Coverage Δ
src/Collection/ArrayCollectionFactory.php 80.00% <ø> (ø)
src/Collection/DoctrineCollectionFactory.php 76.00% <ø> (ø)
src/Collection/IlluminateCollectionFactory.php 66.66% <ø> (ø)
src/Collection/LoophpCollectionFactory.php 72.22% <ø> (ø)
src/Collection/Pivoted/PivotedCollection.php 100.00% <ø> (ø)
src/Factory.php 96.89% <ø> (ø)
src/Mapper/Proxy/ClasslessProxyFactory.php 98.00% <ø> (ø)
src/Mapper/Proxy/ProxyEntityFactory.php 94.52% <ø> (ø)
src/Schema.php 88.03% <ø> (ø)
src/Select/Repository.php 100.00% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roxblnfk roxblnfk marked this pull request as ready for review March 31, 2023 22:48
@roxblnfk roxblnfk requested a review from msmakouz March 31, 2023 22:48
@roxblnfk roxblnfk merged commit 50a2d2d into 2.x Apr 3, 2023
@roxblnfk roxblnfk deleted the feature/jti-filter-by-parent-fields branch April 3, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement. type:feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Parent fiields when fetching entities with JTI
3 participants