Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] Add RouterSource typings and remove typing dependency to switch-path #65

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

JabX
Copy link
Contributor

@JabX JabX commented Jul 2, 2016

Hello,

I tried to setup a Cycle project using Typescript and Cyclic-router but I ran into two issues:

  • makeRouterDriver's typings references RouterSource's, that in turn references switch-path's that aren't included in the build. Thus a typescript app that includes makeRouterDriver cannot compile, which is a problem.
  • The RouterSource typings aren't exposed to consumers, so they can't type their Sources objects. They can be accessed "manually" though, but they're incomplete because they have to work with multiple stream libraires.

With this PR, I attempt to solve these two issues:

  • I added an interfaces.ts files and moved there the two interfaces that were previously in switch-path's typings, so that the resulted .d.ts files do not depend on switch-path. Ideally, adding typings to switch-path could also have solved the problem, but in the meantime we have a solution that doesn't depend on that.
  • I added 4 root .d.ts files containing typings for RouterSource for all supported stream librairies, exactly like @cycle/dom does.

@TylorS
Copy link
Member

TylorS commented Jul 2, 2016

This is awesome! Thank you very much LGTM

@TylorS TylorS merged commit d033b2a into cyclejs-community:master Jul 2, 2016
@TylorS
Copy link
Member

TylorS commented Jul 2, 2016

Published as 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants