Update StreamAdapter interface #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unneccessary `replicate()` function from StreamAdapter API, because it's the exact same as `subscribeToStream()`
Use CycleStreamAdapter.subscribeToStream to convert holdSubject.stream to the proper stream for the driver.
Adding 'module' = 'ES6' is required for the builds to succeed.
Removes unused cycle.js file
Fix 'main' to point to the proper file. Add 'typings' for TypeScript projects to automatically detect this libraries definitions. Add 'browserify' section; This is required to compile the ES6 files when it is located inside of a projects node_modules, otherwise it is assumed to be ES5.
|
What about this PR? Close? |
|
Yes, close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
replicate()from the StreamAdapter interface in favor of reusingsubscribeToStream()as it is the same exact function in practice.Reworks the tests to match the current API.