feat(Cycle): remove dispose() add remember() to adapter interface #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for dispose() in the streamAdapters and adds the ability to represent "values over time" with remember(). Also add logToConsoleError which was previously represented in every stream adapter separately. The StreamAdapter interface no longer has .dipose(), but now has .remember()
Add generic typings where possible
Add a cast() function to the interface to allow typescript drivers to generate awesome type defintions. e.g. StreamAdapter.cast<Event>(DOMSource.select().events())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for dispose() in the streamAdapters and adds the ability to represent "values
over time" with remember(). Also add logToConsoleError which was previously represented in every
stream adapter separately.
The StreamAdapter interface no longer has .dipose(), but now has .remember()