Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser field #30

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Add browser field #30

merged 1 commit into from
Jan 13, 2016

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Jan 13, 2016

Add browser field to load correctlry by browser loaders.

Add browser field to load correctlry by browser loaders.
staltz added a commit that referenced this pull request Jan 13, 2016
@staltz staltz merged commit 5938cbe into cyclejs:master Jan 13, 2016
@staltz
Copy link
Member

staltz commented Jan 13, 2016

Thanks

@wclr
Copy link
Contributor Author

wclr commented Jan 13, 2016

Ok, hope you are not against that in browser there should be loaded prebuild versions from dist folder) without this it tries to load in supseragent -> qs -> fails to do this....

Actually probably other @cycle modules have to have such fileds, though modules I tried load correctly at the time.

@wclr
Copy link
Contributor Author

wclr commented Jan 16, 2016

I thought and would probably revert this one because for browserfy entry point can be nodejs version, and for Systemjs loaders should handle jspm field. I made them separate for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants