Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: instances instead of classes for spec versions #139

Closed
jkowalleck opened this issue Sep 25, 2022 · 0 comments · Fixed by #142
Closed

Spec: instances instead of classes for spec versions #139

jkowalleck opened this issue Sep 25, 2022 · 0 comments · Fixed by #142
Labels
breaking change
Milestone
v2

Comments

@jkowalleck
Copy link
Member

currently every spec is an own class. ala class Spec14 implements Spec { }

proposal: have Spec be a class, and have a factory that creates implmentations for 1.4, 1.3, ...
this factory could use waek references, so t can cache already generated instances, without taking up to much memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

add spec factory CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck