feat: added view pod manifest #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-cvit
requested changes
Sep 3, 2024
There was a problem hiding this comment.
@knav33n thanks for the PR. I left two comments on button styling
| setModal({ on: true }); | ||
| }} | ||
| > | ||
| View Manifest |
There was a problem hiding this comment.
Can you make this <h4>. Also, you can add this icon since other buttons have it - <FileTextOutlined />
Comment on lines
110
to
113
| <PodLogs pod={{ ...pod, namespace }} /> | ||
| <PodManifest pod={{ ...pod, namespace }} /> | ||
| <Col span={12} style={{ paddingRight: 4, marginTop: 10 }}> | ||
| <Button |
There was a problem hiding this comment.
Can you align buttons in the same column so they are one under the other?
|
@petar-cvit thanks for reviewing the PR. I've made the necessary changes to the button styling as per your comments. Let me know if there's anything else! |
petar-cvit
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks @knav33n 🧡
Awesome job on splitting the buttons to components!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #539
📑 Description
✅ Checks
ℹ Additional context