Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rootUrl customization easier #166

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Conversation

vadjs
Copy link
Contributor

@vadjs vadjs commented Mar 5, 2019

Current implementation of rootUrl customization is not very user friendly.
With this changes you can use custom rootUrl much easier. Something like this:

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    ApiModule.forRoot({rootUrl: 'https://some-root-url.com'}),
  ],
  bootstrap: [
    AppComponent
  ]
})
export class AppModule { }

@vadjs
Copy link
Contributor Author

vadjs commented Mar 11, 2019

@luisfpg I hope you not abandoned this repo.

@luisfpg
Copy link
Collaborator

luisfpg commented Mar 11, 2019

@vadjs No, I haven't abandoned. I have plenty of other tasks, so I maintain this project on free time.
I've already started https://github.com/cyclosproject/ng-openapi-gen, but ng-swagger-gen will still be maintained for bug fixes and improvements such as this one you sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants