rong Build option: NO_SECUREZEROMEMORY

[bofhbug]

it apiers only with the 0.71 version the Build option NO_SECUREZEROMEMORY is set.

[cyd01]

This option is necessary to build KiTTY.

[lars18th]

This option is necessary to build KiTTY.

Sorry @cyd01 , you can explain why?
Perhaps a workaround it's possible.

[cyd01]

You are absolutely right. It can compile without it. I can remember when (and why) I've added this compilation flag. Now I have to test all the others: -DAUTO_WINSOCK -DUSE_CAPI -DCOVERITY -DNO_MULTIMON -DNO_HTMLHELP Le ven. 31 mai 2019 à 12:08, Lars The <notifications@github.com> a écrit :

…

This option is necessary to build KiTTY. Sorry @cyd01 <https://github.com/cyd01> , you can explain why? Perhaps a workaround it's possible. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AIESOBXQGOJHCCYZBGSDVF3PYD2JLA5CNFSM4HOXHYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUZ62A#issuecomment-497655656>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIESOBRXCZXGTGK3KGSQJOLPYD2JLANCNFSM4HOXHYDA> .

[lars18th]

Now I have to test all the others […]

So please reopen this issue (you can @cyd01 as moderator) until you finish it.

[cyd01]

USE_CAPI is necessary for WINCRYPTPORT. As it is broken with PuTTY 0.71, I remove it. I need NO_HTMLHELP because my environment does not have htmlhelp.h (from winhelp.c). I need NO_MULTIMON because my environment does not have multimon.h (from window.c) I need COVERITY because CRYPTPROTECTMEMORY_BLOCK_SIZE and CRYPTPROTECTMEMORY_CROSS_PROCESS are unknown (in winshare.c) I need AUTO_WINSOCK because without it ERROR_BROKEN_PIPE and BROKEN_PIPE_ERROR_CODE are unknown (in sshshare.c). Le ven. 31 mai 2019 à 13:09, Cyril DUPONT <cyrildupont71@gmail.com> a écrit :

…

You are absolutely right. It can compile without it. I can remember when (and why) I've added this compilation flag. Now I have to test all the others: -DAUTO_WINSOCK -DUSE_CAPI -DCOVERITY -DNO_MULTIMON -DNO_HTMLHELP Le ven. 31 mai 2019 à 12:08, Lars The ***@***.***> a écrit : > This option is necessary to build KiTTY. > > Sorry @cyd01 <https://github.com/cyd01> , you can explain why? > Perhaps a workaround it's possible. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#18?email_source=notifications&email_token=AIESOBXQGOJHCCYZBGSDVF3PYD2JLA5CNFSM4HOXHYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUZ62A#issuecomment-497655656>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AIESOBRXCZXGTGK3KGSQJOLPYD2JLANCNFSM4HOXHYDA> > . >

[lars18th]

Hi @cyd01 ,

USE_CAPI

I recommend to not include any CAPI/CAC support inside KiTTY. For this functionality it's preferable to use the Pageant from the PuTTY-CAC project: https://github.com/NoMoreFood/putty-cac

NO_HTMLHELP
NO_MULTIMON

Ok.

COVERITY

Umm... CRYPTPROTECTMEMORY_BLOCK_SIZE and CRYPTPROTECTMEMORY_CROSS_PROCESS are defined (if not) in winshare.c:
https://github.com/github/putty/blob/49fb598b0e78d09d6a2a42679ee0649df482090e/windows/winshare.c#L29

AUTO_WINSOCK

BROKEN_PIPE_ERROR_CODE is defined as ERROR_BROKEN_PIPE:
https://github.com/github/putty/blob/49fb598b0e78d09d6a2a42679ee0649df482090e/windows/winstuff.h#L112

And ERROR_BROKEN_PIPE (109L) is part of the Windows Errors:
https://www.rpi.edu/dept/cis/software/g77-mingw32/include/winerror.h

So review the dependencies, please.

[lars18th]

Hi,

This issue can be closed?

[cyd01]

yes Le ven. 14 juin 2019 à 11:14, Lars The <notifications@github.com> a écrit :

…

Hi, This issue can be closed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AIESOBXQ6NV655B2TXZ34IDP2NOP5A5CNFSM4HOXHYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWHEMQ#issuecomment-502034994>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIESOBSHBYJ7IA7CZCCXEETP2NOP5ANCNFSM4HOXHYDA> .

[lars18th]

So, please @cyd01 do it!
Only the original author and the owner of the repo can close it. 😉

[cyd01]

The compilation directive -DNO_SECUREZEROMEMORY was removed from Makefile.