Refine DB Revamped & Refine UI support #10

cydh · 2018-07-09T15:05:35Z

Excuse

A clean up of #9 that I updated it by merging it from master but one day I rebase it 🙊

The changes

Zero

The structures explained in this separated gist file. Read

One

Refine cost type is changed to

REFINE_COST_NORMAL         - For normal refining
REFINE_COST_OVER10         - For refining over +10
REFINE_COST_HD             - For refining with HD ores
REFINE_COST_ENRICHED       - For refining with enriched ores
REFINE_COST_OVER10_HD      - For refining over +10 with HD ores
REFINE_COST_HOLINK         - For refining at Holink in Malangdo
REFINE_COST_WAGJAK         - For refining at Refining Machine Wagjak in the Novice Academy
REFINE_COST_BLESSED        - For refining using Blessed Ore
REFINE_COST_EVT_ENRICHED   - For refining with enriched ores with event rates
REFINE_COST_EVT_OVER10_HD  - For refining over +10 with HD ores with event rates

Two

Changed getequippercentrefinery(<equipment slot>{,<enriched>,<char_id>})
To: getequippercentrefinery(<equipment slot>,<type>{,<char_id>})
The enriched flag (boolean) is removed by type

Three

See on refine_db.yml, it's more ~~complicated~~ detailed now to support Refine UI that will show the correct materials based on equipment and its refine level, such

Enriched ore are always be shown to refine from +0 to +10
HD ores limitation and downgrade
Blacksmith Blessing options

If you are using custom refiner (that excluded from this changes) make sure you check again that I separated the REFINE_COST_NORMAL and normal for REFINE_COST_OVER10, because before +10 for Armor as example needs Elunium but until +20 is Carnium. If you force to use 'REFINE_COST_NORMAL' for refining to +11, it gives you 0% success rate and gives no material ID.

Four

About to 'separate' equip to its own materials (include chances and costs). Read this comment

Disclaimer

There are many credits by every commits, see yourself. Use this by your own risk such that maybe conflicted with your server or conflicted on future update on rAthena. I don't accept any support about "can you make it ..." related this changes, except as paid request.
This branch/PR includes

Released of the refine UI by Lemongrass3110 on Initial release of the refine UI rathena/rathena#2494
Added 'Blacksmith blessing' system in refine npcs by Atemo on Initial release of the refine UI rathena/rathena#2494
Checked out from https://github.com/rathena/rathena/tree/feature/refineui branch, so this refine_db.yml includes the update on Holink and Wajnak

@cydh

Thanks to @cydh

Thanks to @anity99

Added a new configuration values in the YAML configuration to mark if a material will break or downgrade the item in case of failure.

@ecdarreola

… to @ecdarreola Signed-off-by: Cydh Ramdh <cydh@pservero.com>

…ammer)

# Conflicts: # src/map/script.cpp

* Updated it to the proper constant name.

# Conflicts: # conf/battle/feature.conf # db/re/refine_db.yml # npc/re/merchants/hd_refiner.txt # src/map/atcommand.cpp # src/map/battle.cpp # src/map/battle.hpp # src/map/clif.cpp # src/map/pc.hpp # src/map/script.cpp

# Conflicts: # conf/msg_conf/map_msg.conf

# Conflicts: # src/map/script.cpp

* Enabled Blacksmith Blessing check for refining to disable downrefine on fail! (of course without breaking the refined item) * +7 to +8 needs 1 ea * +8 to +9 needs 2 ea * +9 to +10 needs 4 ea * +10 to +11 needs 7 ea * +11 to +12 needs 11 ea * Added Blacksmith Blessing entries to refine_db.yml follow the values above. * Fixed refine_info clearances on loading files. Signed-off-by: Cydh Ramdh <cydh@pservero.com>

* HD Oridecon & HD Elunium only can be used to update equip with refine level +7 to +9. It means +7 -> +8, +8 -> +9, +9 -> +10. * Enriched Oridecon & Enriched Elunium are just replacement of normal materials. It means only can be used to refine up to +10. * Corrected `true = enriched` flag for `getequippercentrefinery` commands. HD just simply use normal rates, not enriched. Or create new value for HDs later Signed-off-by: Cydh Ramdh <cydh@pservero.com>

* You are now allowed to add your own refine costs/chances! * Say goodbye to `event_refine_chance` config. If you need 'event'-like chance, just add the chance value and use that type for `getequippercentrefinery` command, just like its bro `getequiprefinecost`. * To disable certain refine material (based on refine cost/type) on certain refine level/type, just remove its value from it! * The most important,see your refine_db.yml now, the refine rates are using refine cost types. If you have custom values, just simply adjust it. * There are Blessed Oridecon/Elunium from `blessed_refiner` NPC to refine_db.yml but it won't be displayed in NEW Refine UI, why? Because the `RefineUI` value in refine_db.yml is set as `false`. * technically Over +10 is 'normal' rates, just have different material, so the `REFINE_COST_NORMAL` never be in +11 to +20 so does `REFINE_COST_OVER10` will never be in below +10. There are also HD, Enriched, and Blessed ores with this refine level restriction. Signed-off-by: Cydh Ramdh <cydh@pservero.com>

* 'Break' is percentage number to break the equip on fail, 100 = 100% * 'DownRefine' is percentage number to downrefine the equip on fail, 100 = 100% (checked after 'Break' chance if passed) * 'DownRefineNum' is number of down refine

* `getblacksmithblessing(<type>,<refine>{,<var>})` to get info of Blacksmith Blessing usage for refining

* Removed unnecessary changes were changed on merge * Updated `getequippercentrefinery` to allow without type

ghost · 2018-07-12T02:00:34Z

There's a warning for the event_refince_chance on this PR since it was removed.

Need to delete it in battle/items.conf

kukas9 · 2019-02-16T11:19:13Z

No news? @cydh :(

Brog, voce ta usando o emulador dele ou voce pegou as mudanças que foram feitas nos arquivos e colocou direto no seu emulador?

luan122 · 2019-03-08T11:07:30Z

Could you update this for the latest version of rA?

# Conflicts: # conf/battle/feature.conf # src/map/atcommand.cpp # src/map/battle.cpp # src/map/clif.cpp # src/map/clif_packetdb.hpp # src/map/script.cpp

luan122 · 2019-03-11T02:36:36Z

Thank you!

iubantot · 2019-08-13T10:00:29Z

Sorry for the noob question but im using the latest rathena and is it possible to fetch this pull request? if yes then how?

cydh · 2019-12-04T01:31:03Z

seems gonna make diff just for refine ui only without the script changes 🤔

admkakaroto · 2019-12-29T15:55:03Z

@cydh crash on map_server:

Core was generated by `./map-server'.
Program terminated with signal 11, Segmentation fault.
#0  0x000000000051ebcf in pc_delitem (sd=sd@entry=0x88879c0, n=n@entry=65535,
    amount=amount@entry=1, type=type@entry=0, reason=reason@entry=0,
    log_type=log_type@entry=LOG_TYPE_CONSUME) at pc.cpp:5015
5015            if(n < 0 || sd->inventory.u.items_inventory[n].nameid == 0 || amount <= 0 || sd->inventory.u.items_inventory[n].amount<amount || sd->inventory_data[n] == NULL)
Missing separate debuginfos, use: debuginfo-install glibc-2.17-260.el7_6.6.x86_64 keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-37.el7_6.x86_64 libcom_err-1.42.9-13.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 libselinux-2.5-14.1.el7.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 mariadb-libs-5.5.60-1.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64
(gdb) bt full
#0  0x000000000051ebcf in pc_delitem (sd=sd@entry=0x88879c0, n=n@entry=65535,
    amount=amount@entry=1, type=type@entry=0, reason=reason@entry=0,
    log_type=log_type@entry=LOG_TYPE_CONSUME) at pc.cpp:5015
No locals.
#1  0x0000000000495627 in clif_parse_refineui_refine (fd=33, sd=0x88879c0) at clif.cpp:21841
        i = <optimized out>
        index = <optimized out>
        material = <optimized out>
        use_blacksmith_blessing = false
        materials = {{cost = {nameid = 985, zeny = 2000, refineui = true, breaking = 100,
              downrefine = 0, downrefine_num = 0}, chance = 12 '\f', bs_bless = {nameid = 0,
              count = 0}}, {cost = {nameid = 6241, zeny = 20000, refineui = true, breaking = 0,
              downrefine = 100, downrefine_num = 1}, chance = 9 '\t', bs_bless = {nameid = 0,
              count = 0}}, {cost = {nameid = 7619, zeny = 2000, refineui = true, breaking = 100,
              downrefine = 0, downrefine_num = 0}, chance = 20 '\024', bs_bless = {nameid = 0,
              count = 0}}, {cost = {nameid = 6439, zeny = 20000, refineui = true, breaking = 0,
              downrefine = 0, downrefine_num = 1}, chance = 12 '\f', bs_bless = {nameid = 0,
              count = 0}}, {cost = {nameid = 0, zeny = 0, refineui = false, breaking = 0,
              downrefine = 0, downrefine_num = 0}, chance = 0 '\000', bs_bless = {nameid = 6635,
              count = 4}}}
        j = 65535
        item = 0x88a2c20
        id = 0x7f90477194cc
#2  0x000000000046b709 in clif_parse (fd=33) at clif.cpp:22293
        cmd = 2723
        packet_len = 7
        sd = 0x88879c0
        pnum = 0
#3  0x00000000006306ad in do_sockets (next=<optimized out>) at socket.cpp:1407
        rfd = {fds_bits = {8589934592, 0 <repeats 15 times>}}
        timeout = {tv_sec = 0, tv_usec = 3315}
        ret = 0
        i = 33
#4  0x000000000040764d in main (argc=1, argv=0x7fffc68cd758) at core.cpp:369
---Type <return> to continue, or q <return> to quit---
        next = <optimized out>
(gdb)

Badarosk0 · 2020-01-18T17:06:41Z

Can you update this PR to the latest version of rAthena? Thank you

RagnaWay · 2020-01-21T10:03:00Z

@cydh please update.

Chywoner · 2020-03-12T14:42:35Z

Could someone help me with this error?

LordWhiplash · 2020-04-22T23:18:53Z

Working perfectly, thank you!

iubantot · 2020-04-23T15:31:15Z

is blessed ores not yet supported? its not showing on materials that i can use

LolyAll · 2020-05-18T13:14:00Z

Hello @cydh , could you update to work with Lemon's PR? That of the new clients, using version 2020, the list of materials does not appear in the UI, only the blessing is showing, the other items appear as unknown.

hoosaa9 · 2020-06-02T15:47:18Z

@cydh please update.

ecdarreola · 2020-06-05T08:54:13Z

Shadow items can be refined using RefineUI and use blacksmith's blessing even it is commented out on refine_db.yml

Badarosk0 · 2020-06-05T13:56:59Z

@cydh Could you update this PR with the current rAthena?

RagnaWay · 2020-06-07T17:07:08Z

https://rathena.org/board/topic/124590-refineui-cydh/

This reverts commit ccf09e3.

zdurexz · 2020-10-22T10:06:01Z

@cydh Help, New #4335 can not use refineui as picture

@Atemo

* Corrected script for some item #10 * add some items JRO costume Thanks to @Atemo

Lemongrass3110 and others added 28 commits October 9, 2017 14:58

Initial release of the refine UI

82217a4

Added a missing index check

b9858f7

Thanks to @cydh

Added a logic check for the feature configuration

ed664a3

Thanks to @anity99

Added a feature check for existing refiners

0a2d6c1

Added downgrade logic

db82c45

Added a new configuration values in the YAML configuration to mark if a material will break or downgrade the item in case of failure.

Sanity check for current refine level

d50cb66

Fixed Refine UI doesn't update the refine value on downrefine. Thanks…

fe391b0

… to @ecdarreola Signed-off-by: Cydh Ramdh <cydh@pservero.com>

Added 'Blacksmith blessing' system in refine npcs (Basta and Mighty h…

9c155ac

…ammer)

Updated script accordly @cydh comment

2f008a5

Merge branch 'master' into feature/refineui

7ae8826

# Conflicts: # src/map/script.cpp

Merge branch 'master' into feature/refineui

0b83ac7

Merge branch 'master' into feature/refineui

0864ba9

Corrected an emotion constant

b532dfe

* Updated it to the proper constant name.

Merge branch 'master' into feature/refineui

a88f3a6

Merge branch 'master' into feature/refineui

fc61f81

# Conflicts: # conf/battle/feature.conf # db/re/refine_db.yml # npc/re/merchants/hd_refiner.txt # src/map/atcommand.cpp # src/map/battle.cpp # src/map/battle.hpp # src/map/clif.cpp # src/map/pc.hpp # src/map/script.cpp

Merge branch 'master' into feature/refineui

4c80179

# Conflicts: # conf/msg_conf/map_msg.conf

Merge branch 'master' into refactor/refine_db-2.3.1

1b2a99e

# Conflicts: # src/map/script.cpp

Constant update

7dcfce2

Rework on Refine DB Refactor

50b0e5c

Removed 'Breakable', added 'OnFail'

3c41b17

* 'Break' is percentage number to break the equip on fail, 100 = 100% * 'DownRefine' is percentage number to downrefine the equip on fail, 100 = 100% (checked after 'Break' chance if passed) * 'DownRefineNum' is number of down refine

Added RefineUI: false for Wagjak and Holink

1838878

Wagjak rate is using Normal Rate

3bae922

Added getblacksmithblessing

17952fb

* `getblacksmithblessing(<type>,<refine>{,<var>})` to get info of Blacksmith Blessing usage for refining

A little clean up

3d3cda2

* Removed unnecessary changes were changed on merge * Updated `getequippercentrefinery` to allow without type

Typo in getblacksmithblessing usages

5acae3c

cydh mentioned this pull request Jul 9, 2018

Refine UI Implementation & Refine DB Revamped #9

Closed

Merge branch 'master' into refactor/refine_db-2.3

f1b2a14

# Conflicts: # conf/battle/feature.conf # src/map/atcommand.cpp # src/map/battle.cpp # src/map/clif.cpp # src/map/clif_packetdb.hpp # src/map/script.cpp

cydh added 5 commits March 31, 2019 16:24

Merge branch 'master' into refactor/refine_db-2.3

3ca66c7

Merge branch 'master' into refactor/refine_db-2.3

5dc540e

Merge branch 'master' into refactor/refine_db-2.3

e65790e

Merge branch 'master' into refactor/refine_db-2.3

881bade

Set feature.refineui to 3

a070939

Merge branch 'master' into refactor/refine_db-2.3

b7f3db0

cydh added 2 commits April 23, 2020 01:55

Merge branch 'master' into refactor/refine_db-2.3

2cae7f3

follow up 2cae7f3

5c72664

napatkung added a commit to napatkung/rathena that referenced this pull request Jun 14, 2020

https://github.com/cydh/rathena/pull/10

ccf09e3

napatkung added a commit to napatkung/rathena that referenced this pull request Jun 14, 2020

Revert "cydh#10"

1a72d5b

This reverts commit ccf09e3.

gravity-ro referenced this pull request in rathena/rathena Jul 30, 2021

Fixed refine UI in newer clients

5f73331

cydh pushed a commit that referenced this pull request Nov 29, 2022

Corrected script for some item #10 (rathena#7177)

58a7f36

* Corrected script for some item #10 * add some items JRO costume Thanks to @Atemo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refine DB Revamped & Refine UI support #10

Refine DB Revamped & Refine UI support #10

cydh commented Jul 9, 2018 •

edited

Loading

ghost commented Jul 12, 2018

kukas9 commented Feb 16, 2019

luan122 commented Mar 8, 2019

luan122 commented Mar 11, 2019

iubantot commented Aug 13, 2019

cydh commented Dec 4, 2019

admkakaroto commented Dec 29, 2019

Badarosk0 commented Jan 18, 2020

RagnaWay commented Jan 21, 2020

Chywoner commented Mar 12, 2020

LordWhiplash commented Apr 22, 2020

iubantot commented Apr 23, 2020

LolyAll commented May 18, 2020

hoosaa9 commented Jun 2, 2020

ecdarreola commented Jun 5, 2020

Badarosk0 commented Jun 5, 2020

RagnaWay commented Jun 7, 2020

zdurexz commented Oct 22, 2020

Refine DB Revamped & Refine UI support #10

Are you sure you want to change the base?

Refine DB Revamped & Refine UI support #10

Conversation

cydh commented Jul 9, 2018 • edited Loading

Excuse

The changes

Zero

One

Two

Three

Four

Disclaimer

ghost commented Jul 12, 2018

kukas9 commented Feb 16, 2019

luan122 commented Mar 8, 2019

luan122 commented Mar 11, 2019

iubantot commented Aug 13, 2019

cydh commented Dec 4, 2019

admkakaroto commented Dec 29, 2019

Badarosk0 commented Jan 18, 2020

RagnaWay commented Jan 21, 2020

Chywoner commented Mar 12, 2020

LordWhiplash commented Apr 22, 2020

iubantot commented Apr 23, 2020

LolyAll commented May 18, 2020

hoosaa9 commented Jun 2, 2020

ecdarreola commented Jun 5, 2020

Badarosk0 commented Jun 5, 2020

RagnaWay commented Jun 7, 2020

zdurexz commented Oct 22, 2020

cydh commented Jul 9, 2018 •

edited

Loading