fix: sequelize mode support HAVING, and select fields raw sql support #187

JimmyDaddy · 2021-09-27T08:19:15Z

No description provided.

src/spell.js

test/unit/adapters/sequelize.test.js

codecov-commenter · 2021-09-27T09:03:38Z

Codecov Report

Merging #187 (c191bd5) into master (5d06e6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   96.79%   96.80%           
=======================================
  Files          39       39           
  Lines        2963     2969    +6     
=======================================
+ Hits         2868     2874    +6     
  Misses         95       95

Impacted Files	Coverage Δ
src/adapters/sequelize.js	`94.59% <100.00%> (+0.05%)`	⬆️
src/spell.js	`94.86% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d06e6e...c191bd5. Read the comment docs.

src/spell.js

cyjake · 2021-09-27T09:35:36Z

src/spell.js

-      const condition = parseObjectValue(value);
-      normalizeLogicalCondition(condition, name);
-      result.push(condition);
+      const conds = parseObjectValue(value);


maybe we can use parseOperatorCondition(name, value) here

tried a bit, with no luck. I'd need more time to investigate on this.

parseOperatorCondition seems can't parse logical operator and return object not object array

fix: sequlize mode support HAVING, and raw sql support

c37b421