Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Remove redundant lines under package requirements #5

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

sadielbartholomew
Copy link
Collaborator

@sadielbartholomew sadielbartholomew commented Aug 23, 2019

I noticed there are identical lines under each of the host & run sections for the cylc-flow package requirements in the conda overarching recipe. These can obviously be removed without any influence on the recipe build behaviour.

From this, I was wondering if it would perhaps be sensible to list packages under such sections in alphabetical order (or perhaps those with definitive version ranges listed alphabetically, then those without alphabetically, or similar) to make it easier to pick out packages, & prevent any duplication in future, when lists may be extended?

Trivial, hence one reviewer sufficient.

@kinow
Copy link
Member

kinow commented Aug 24, 2019

Another good spot! Thanks @sadielbartholomew !

@kinow kinow merged commit c6aacd9 into cylc:master Aug 24, 2019
@kinow
Copy link
Member

kinow commented Aug 24, 2019

From this, I was wondering if it would perhaps be sensible to list packages under such sections in alphabetical order (or perhaps those with definitive version ranges listed alphabetically, then those without alphabetically, or similar) to make it easier to pick out packages, & prevent any duplication in future, when lists may be extended?

Sounds like a good idea, no objection. It will be easier to spot duplicates, as well as confirming certain library is or is not in the list.

@kinow
Copy link
Member

kinow commented Aug 24, 2019

Let me move that to another issue.

@sadielbartholomew sadielbartholomew deleted the remove-duplicate-requirements branch August 24, 2019 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants