-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on markupsafe #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
src/installation.rst
Outdated
Comment on lines
46
to
49
# workaround jinja2 bug in Cylc 8.0rc1 | ||
$ pip install 'markupsafe<2.1' | ||
|
||
$ pip install cylc-flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# workaround jinja2 bug in Cylc 8.0rc1 | |
$ pip install 'markupsafe<2.1' | |
$ pip install cylc-flow | |
$ pip install 'markupsafe<2.1' cylc-flow |
src/installation.rst
Outdated
Comment on lines
41
to
42
For Cylc 8.0rc1, a bug in the currently used version of Jinja2 means you | ||
will have to manually install ``markupsafe`` at less than version 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Only for pip installs)
26 tasks
oliver-sanders
approved these changes
Feb 21, 2022
MetRonnie
added a commit
to MetRonnie/cylc-doc
that referenced
this pull request
Feb 21, 2022
This reverts commit a9805b5.
MetRonnie
added a commit
to MetRonnie/cylc-doc
that referenced
this pull request
Feb 21, 2022
This reverts commit a9805b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to cylc/cylc-flow#4703
As soon as this is merged I will open a PR for 8.0rc2 that undoes this