Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on markupsafe #408

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Conversation

MetRonnie
Copy link
Member

Sibling to cylc/cylc-flow#4703

As soon as this is merged I will open a PR for 8.0rc2 that undoes this

@MetRonnie MetRonnie added this to the 8.0rc1 milestone Feb 21, 2022
@MetRonnie MetRonnie self-assigned this Feb 21, 2022
Comment on lines 46 to 49
# workaround jinja2 bug in Cylc 8.0rc1
$ pip install 'markupsafe<2.1'

$ pip install cylc-flow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# workaround jinja2 bug in Cylc 8.0rc1
$ pip install 'markupsafe<2.1'
$ pip install cylc-flow
$ pip install 'markupsafe<2.1' cylc-flow

Comment on lines 41 to 42
For Cylc 8.0rc1, a bug in the currently used version of Jinja2 means you
will have to manually install ``markupsafe`` at less than version 2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Only for pip installs)

@oliver-sanders oliver-sanders mentioned this pull request Feb 21, 2022
26 tasks
@oliver-sanders oliver-sanders merged commit a9805b5 into cylc:master Feb 21, 2022
@MetRonnie MetRonnie deleted the markupsafe-note branch February 21, 2022 13:40
MetRonnie added a commit to MetRonnie/cylc-doc that referenced this pull request Feb 21, 2022
MetRonnie added a commit to MetRonnie/cylc-doc that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants