Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcylc dot-view: collapse and expand individual namespaces #1881

Merged

Conversation

oliver-sanders
Copy link
Member

Closes #132
Families can now be expanded/collapsed in the dot view.

@hjoliver Please Review
@benfitzpatrick Please Review

@oliver-sanders oliver-sanders added this to the soon milestone Jun 9, 2016
@matthewrmshin matthewrmshin modified the milestones: next release, soon Jun 9, 2016
@hjoliver
Copy link
Member

I've been playing with this with the examples/task-states suite, which has one family. I'm getting quite frequent exceptions like this:

/home/vagrant/cylc/cylc.git/lib/cylc/gui/updater_dot.py:296: Warning: Source ID 5244 was not found when attempting to remove it
  self.led_liststore.clear()

Also, family-expand sometimes has no effect, and sometimes it quickly collapses again by itself. @oliver-sanders - do you see these problems?

@oliver-sanders oliver-sanders force-pushed the 132.dot-view-collapse-expand-namespaces branch from 0d9beae to f9eb9ca Compare June 15, 2016 09:35
@oliver-sanders
Copy link
Member Author

@hjoliver Fixed:

  • Issue where rows collapse on state change
  • Issue where clicking on families in transpose mode has no effect

I was unable to replicate your warning message, please say if it persists.

@hjoliver
Copy link
Member

(as discussed) warning messages still emitted, only for the non-transposed view.

@oliver-sanders oliver-sanders force-pushed the 132.dot-view-collapse-expand-namespaces branch from 26209b4 to e381dc2 Compare June 16, 2016 09:15
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Jun 16, 2016

@hjoliver e381dc2 should suppress these warnings.

@@ -28,9 +26,16 @@
from cylc.network.suite_state import get_id_summary
from copy import deepcopy

import warnings
warnings.filterwarnings('ignore', 'use the new', Warning)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working - second arg should match the warning message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp, have updated the string accordingly.

@oliver-sanders oliver-sanders force-pushed the 132.dot-view-collapse-expand-namespaces branch from e381dc2 to 4422e16 Compare June 17, 2016 14:27
for task in tasks:
if task in self.task_list:
self.task_list.remove(task)
self.task_list = self.task_list[:ind - 1] + [heading] +\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the rest of the code, it's better to use brackets for continuation lines

@benfitzpatrick
Copy link
Contributor

Can we flip the triangle so it points towards the name in non-expanded mode? I think that is the right direction (with my head on its side).

@oliver-sanders oliver-sanders force-pushed the 132.dot-view-collapse-expand-namespaces branch 2 times, most recently from 3346769 to db320f9 Compare June 21, 2016 16:38
@oliver-sanders
Copy link
Member Author

@benfitzpatrick Addressed comments.

@hjoliver
Copy link
Member

If I start up in the transposed state, the family won't expand.

@oliver-sanders oliver-sanders force-pushed the 132.dot-view-collapse-expand-namespaces branch from db320f9 to c8b7fdc Compare June 23, 2016 09:09
@oliver-sanders
Copy link
Member Author

@hjoliver, @benfitzpatrick

  • Fixed the startup in transpose state bug.
  • c8b7fdc Fixes a bug whereby the transpose view icon in the view's toolbar is not set with the correct state when setting transpose <dot/graph> = True in the gcylc.rc file.

@hjoliver
Copy link
Member

That's got it, thanks. Ben agrees on merge.

@hjoliver hjoliver merged commit 11ad090 into cylc:master Jun 23, 2016
@oliver-sanders oliver-sanders deleted the 132.dot-view-collapse-expand-namespaces branch May 23, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants