-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcylc dot-view: collapse and expand individual namespaces #1881
gcylc dot-view: collapse and expand individual namespaces #1881
Conversation
I've been playing with this with the
Also, family-expand sometimes has no effect, and sometimes it quickly collapses again by itself. @oliver-sanders - do you see these problems? |
0d9beae
to
f9eb9ca
Compare
@hjoliver Fixed:
I was unable to replicate your warning message, please say if it persists. |
(as discussed) warning messages still emitted, only for the non-transposed view. |
26209b4
to
e381dc2
Compare
@@ -28,9 +26,16 @@ | |||
from cylc.network.suite_state import get_id_summary | |||
from copy import deepcopy | |||
|
|||
import warnings | |||
warnings.filterwarnings('ignore', 'use the new', Warning) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't working - second arg should match the warning message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derp, have updated the string accordingly.
e381dc2
to
4422e16
Compare
for task in tasks: | ||
if task in self.task_list: | ||
self.task_list.remove(task) | ||
self.task_list = self.task_list[:ind - 1] + [heading] +\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the rest of the code, it's better to use brackets for continuation lines
Can we flip the triangle so it points towards the name in non-expanded mode? I think that is the right direction (with my head on its side). |
3346769
to
db320f9
Compare
@benfitzpatrick Addressed comments. |
If I start up in the transposed state, the family won't expand. |
db320f9
to
c8b7fdc
Compare
|
That's got it, thanks. Ben agrees on merge. |
Closes #132
Families can now be expanded/collapsed in the dot view.
@hjoliver Please Review
@benfitzpatrick Please Review