Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @lumino/default-theme to v2 #1260

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@lumino/default-theme ^0.22.0 -> ^2.0.0 age adoption passing confidence

Release Notes

jupyterlab/lumino

v2.1.1

Compare Source

(Full Changelog)

Bugs fixed
Contributors to this release

(GitHub contributors page for this release)

@​GordonSmith

v2.1.0

Compare Source

v2.0.1

Compare Source

v2.0.0

Compare Source

v0.22.9

Compare Source

v0.22.8

Compare Source

v0.22.7

Compare Source

v0.22.6

Compare Source

v0.22.5

Compare Source

v0.22.4

Compare Source

v0.22.3

Compare Source

v0.22.2

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 15, 2023
@MetRonnie MetRonnie marked this pull request as draft March 16, 2023 10:35
@renovate renovate bot changed the title fix(deps): update dependency @lumino/default-theme to v2 fix(deps): update dependency @lumino/default-theme to v2 - autoclosed Mar 27, 2023
@renovate renovate bot closed this Mar 27, 2023
@renovate renovate bot deleted the renovate/lumino-default-theme-2.x branch March 27, 2023 08:52
@renovate renovate bot changed the title fix(deps): update dependency @lumino/default-theme to v2 - autoclosed fix(deps): update dependency @lumino/default-theme to v2 Mar 27, 2023
@renovate renovate bot reopened this Mar 27, 2023
@renovate renovate bot restored the renovate/lumino-default-theme-2.x branch March 27, 2023 11:17
@renovate renovate bot force-pushed the renovate/lumino-default-theme-2.x branch 2 times, most recently from 17842e2 to 22931e8 Compare April 2, 2023 22:33
@MetRonnie MetRonnie added this to the 2.1.0 milestone Apr 13, 2023
@renovate renovate bot force-pushed the renovate/lumino-default-theme-2.x branch 3 times, most recently from ff14531 to d296591 Compare May 2, 2023 23:05
@renovate renovate bot force-pushed the renovate/lumino-default-theme-2.x branch 7 times, most recently from 3db55a2 to c7f2d80 Compare May 24, 2023 15:33
@renovate renovate bot force-pushed the renovate/lumino-default-theme-2.x branch 2 times, most recently from 739ac47 to a8b13e5 Compare June 1, 2023 10:37
@renovate renovate bot force-pushed the renovate/lumino-default-theme-2.x branch from a8b13e5 to bf21ea0 Compare June 1, 2023 14:54
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this seems to work fine, I couldn't see any visual difference between this and our current version.

@oliver-sanders oliver-sanders marked this pull request as ready for review June 1, 2023 15:05
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at code changes it's just removed deprecated class names from the CSS.

And this which removes the need for a line in our vite.config.js:

image

@renovate
Copy link
Contributor Author

renovate bot commented Jun 1, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@MetRonnie MetRonnie self-assigned this Jun 9, 2023
@MetRonnie MetRonnie merged commit ab43773 into master Jun 12, 2023
@MetRonnie MetRonnie deleted the renovate/lumino-default-theme-2.x branch June 12, 2023 15:03
@MetRonnie MetRonnie modified the milestones: 2.1.0, 2.0.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants