Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwchem tests 1.0 + minor fixes #11

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

zarkoivkovicc
Copy link
Contributor

No description provided.

Copy link
Collaborator

@RaphaelRobidas RaphaelRobidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition, great job! There are just a couple changes to be made.

ccinput/packages/nwchem.py Show resolved Hide resolved
ccinput/packages/nwchem.py Outdated Show resolved Hide resolved
ccinput/tests/test_nwchem.py Outdated Show resolved Hide resolved
ccinput/tests/test_nwchem.py Show resolved Hide resolved
ccinput/tests/test_nwchem.py Outdated Show resolved Hide resolved
ccinput/tests/test_nwchem.py Outdated Show resolved Hide resolved
@zarkoivkovicc
Copy link
Contributor Author

I think I fixed everything now

Copy link
Collaborator

@RaphaelRobidas RaphaelRobidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the revision. There a small typo, but you can correct it in a future PR.

@@ -450,11 +450,13 @@ def to_xtb(self):

def to_nwchem(self):
ids_str = " ".join([str(i) for i in self.ids])
converstion_factor = 1.00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type in "conversion"

@RaphaelRobidas RaphaelRobidas merged commit 95b8b77 into cyllab:main Jun 12, 2023
@zarkoivkovicc zarkoivkovicc deleted the nwchem branch June 12, 2023 17:05
@zarkoivkovicc zarkoivkovicc restored the nwchem branch June 12, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants