Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add model card toolkit #3

Merged
merged 9 commits into from
Sep 23, 2021
Merged

add model card toolkit #3

merged 9 commits into from
Sep 23, 2021

Conversation

timlrx
Copy link
Contributor

@timlrx timlrx commented Sep 22, 2021

No description provided.

@timlrx
Copy link
Contributor Author

timlrx commented Sep 22, 2021

See if my modified proto schema makes sense?

Notably, I added a ExplainabilityAnalysis and FairnessAnalysis section to QuantitativeAnalysis and have a separate ModelTests section in the main scorecard.

@timlrx
Copy link
Contributor Author

timlrx commented Sep 22, 2021

Have made the changes, see if the latest schema works for you?

jasonho-lynx
jasonho-lynx approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@jasonho-lynx jasonho-lynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! There's a last thing under FairnessAssessment where you may be able to combine the fields into FairnessAnalysis or FairnessReport in some way, but otherwise it looks good!

@timlrx
Copy link
Contributor Author

timlrx commented Sep 22, 2021

Nice, thanks! There's a last thing under FairnessAssessment where you may be able to combine the fields into FairnessAnalysis or FairnessReport in some way, but otherwise it looks good!

No, prefer to leave it as nested so that it is easy to modify each of the analysis section to have more fields if required in the future. Same as QuantitativeAnalysis and ExplainabilityAnalysis

@timlrx
Copy link
Contributor Author

timlrx commented Sep 22, 2021

Remove slice from test. Should not be needed since now it is under metric / report.

@timlrx timlrx merged commit 5cd8cd2 into main Sep 23, 2021
@timlrx timlrx deleted the model-card-toolkit branch October 8, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonho-lynx jasonho-lynx jasonho-lynx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timlrx @jasonho-lynx