Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for read_model_test() in Test class #43

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

jasonho-lynx
Copy link
Contributor

Fix for #42.

  • Manually ran all notebooks successfully
  • Error shows up when trying to read a Test that has not been run yet (sgd_test.run() is commented out):
    image

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cylynx/verifyml/CmFsw2pxrjvrKRSZLhkwwA7VTGPy
✅ Preview: https://verifyml-git-validate-test-cylynx.vercel.app

Copy link
Contributor

@timlrx timlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@jasonho-lynx jasonho-lynx merged commit 412ac1b into main Nov 19, 2021
@jasonho-lynx jasonho-lynx deleted the validate-test branch November 19, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants