-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shinyMobile 2.0.0 blog post #55
Conversation
@MikeJohnPage Currently blocked by posit-dev/shinylive#131 to continue. Will move it to ready when this is fixed. |
Summary
Errors per inputErrors in docs/posts/2021-03-09-seasonal-1.8/index.html
|
@DivadNojnarg just tag me in this chat whenever you want me to check it. Thanks! |
@MikeJohnPage If you ignore the TO DO elements for now (supposed to contain the shinylive demo apps, each code snippet will have a running demo), you can start to review the content in general. To test it, you'll have to install with There will be follow up posts to provide more detailed views about specific elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've left you a few grammatical corrections and suggestions.
|
||
#### How does this work? | ||
|
||
At the time of writting of this blog post, you must install a patched `{brochure}` version with `devtools::install_github("DivadNojnarg/brochure")`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: can users expect this to be changed in the near future? Should a message be put here that they won't have to always use a patched version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have guarantees on that for now. That's why we left "experimental".
TBD